@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

And please check that failing CI pipeline. Maybe run a make lint and a make test before your next update of this PR 😅

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

Yes! notice this is still in progress though

Hi @rubenhoenle👋 all the feedback must have been implemented.

Please notice that I reintroduced the WithRegion(region) during client initialization that you advised against in #1086 (comment). We discussed this internally and we concluded that it's a requirement that we can't change right now. There are some networking restrictions.

I would be very grateful if you could check on whether the region argument is handled correctly because I have some doubts about it.

In order to test the terraform provider binary we used:

terraform {
  required_providers {
    stackit = {
      source = "stackitcloud/stackit"
    }
  }
}

provider "stackit" {
  default_region = "eu01"
}

variable "project_id" {
  type = string
}

resource "stackit_intake_runner" "test_runner" {
  project_id            = var.project_id
  name                  = "test-runner-cli"
  region                = "eu01"
  max_message_size_kib  = 1024
  max_messages_per_hour = 1000
}

# Implicit Region (Uses provider default)
data "stackit_intake_runner" "implicit" {
  project_id = var.project_id
  runner_id  = stackit_intake_runner.test_runner.runner_id
}

data "stackit_intake_runner" "explicit" {
  project_id = var.project_id
  runner_id  = stackit_intake_runner.test_runner.runner_id
  region     = "eu01"
}


output "implicit_read_result" {
  value = "Successfully found runner '${data.stackit_intake_runner.implicit.name}'"
}

output "explicit_read_result" { 
  value = "Successfully found runner '${data.stackit_intake_runner.explicit.name}' in region '${data.stackit_intake_runner.explicit.region}'"
}

I would be very grateful if you could check on whether the region argument is handled correctly because I have some doubts about it.

In fact this collides with

Please notice that I reintroduced the WithRegion(region) during client initialization that you advised against in #1086 (comment). We discussed this internally and we concluded that it's a requirement that we can't change right now. There are some networking restrictions.

Why can't it be changed? Feel free to answer via private chat, we don't have to discuss this here in public.

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

Bot keep this open please